Allow for querying mBeans by predictable (configurable) names. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in the attributes (if it has a name) This allows you to query mbeans by stable name patterns, allowing for reliable instrumentation via JMX between VM instances. I currently use these patches in production (nearly 18 months) to grab pool telemetry with collectd's JMX probe.
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change how mBeans names are generated to include the data source name in the attributes (if it has a name).
This allows you to query mbeans by stable name patterns, allowing for reliable instrumentation via JMX between VM instances.
I currently use these patches in production (nearly 18 months) to grab pool telemetry with collectd's JMX probe. Adding the name attribute to the ObjectName allows me to consistently identify the same mbeans across VM restarts thus providing consistent historical data for telemetry graphs.