-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bundler: fix bugs #1105
bundler: fix bugs #1105
Conversation
@kitsonk I think I fixed all of them. Can you try again? |
Ooops... sorry, I missed this. I am trying now but I am starting to wrap up for my day... |
It's okay, I forget things so well. |
@kdy1 I have re-tested with this branch. Thank you for fixing lots of the bugs. There are still a couple things:
|
@kitsonk Did you invoked typescript::strip before bundling? export * as a from "./a.ts"; works with typescript::strip Also, I got
while trying to build it |
@kdy1 I will take a look again... As far as the building, you would have to clone |
@kdy1 I've looked again, and yes, the loader does the stripping before bundling. Our folding though is a bit more complex than the PR you had done, as we have some other things we need to support. Here is the loader in my PR. I am wondering if some of the other passes are causing the problems/challenges? |
I think stack overflow may not be related to bundler. Also, I can't guess why #1118 is still the issue. |
I'll fix remaining issues with a separate pr |
swc_bundler:
import.meta
(Closes swc_bundler: handling of import.meta in modules #1115)swc_ecma_transforms: