Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix WebSocket frame length byte order for 16-bit length case #126

Merged
merged 1 commit into from
Oct 20, 2024

Conversation

kateinoigakukun
Copy link
Contributor

It must be interpreted as big-endian (network byte order).

It must be interpreted as big-endian (network byte order).
@swhitty swhitty self-requested a review October 19, 2024 23:40
Copy link

codecov bot commented Oct 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.63%. Comparing base (ec371c0) to head (63a52d8).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #126   +/-   ##
=======================================
  Coverage   96.63%   96.63%           
=======================================
  Files          60       60           
  Lines        3504     3504           
=======================================
  Hits         3386     3386           
  Misses        118      118           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@swhitty swhitty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch

Thank you 🙏🏻

@swhitty swhitty merged commit 211b297 into swhitty:main Oct 20, 2024
9 checks passed
@swhitty
Copy link
Owner

swhitty commented Oct 20, 2024

I've pushed another end to end test for this one also 85af387

@swhitty
Copy link
Owner

swhitty commented Oct 20, 2024

Included in 0.19.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants