Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove AnySocketAddress #135

Merged
merged 1 commit into from
Nov 23, 2024
Merged

remove AnySocketAddress #135

merged 1 commit into from
Nov 23, 2024

Conversation

swhitty
Copy link
Owner

@swhitty swhitty commented Nov 23, 2024 •
edited
Loading

struct AnySocketAddress should not be needed as any SocketAddress can box all addresses and can then be unwrapped to sockaddr_storage when required to be used.

replace (some SocketAddress)? = nil with (any SocketAddress)? = nil so callers of this method do not need to provide a concrete type and can instead provide nil

@swhitty swhitty merged commit 13778ca into main Nov 23, 2024
21 of 26 checks passed
@swhitty swhitty deleted the remove-AnySocketAddress branch November 23, 2024 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@swhitty