Joseph's Comments

include/albatross/src/details/error_handling.hpp

@@ -18,6 +18,16 @@ namespace albatross {
 #define ALBATROSS_FAIL(dummy, msg)                                             \
   { static_assert(delay_static_assert<dummy>::value, msg); }
 
+/*
+ * Setting ALBATROSS_FAIL to "= delete" as below will slightly
+ * change the behavior of failures.  In some situations
+ * inspection of return types can trigger the delay_static_assert
+ * approach above, while the deleted function approach may
+ * work fine.  In general however the deleted function approach
+ * leads to slightly more confusing compile errors since it
+ * isn't possible to include an error message.
+ */
+
 //#define ALBATROSS_FAIL(dummy, msg) = delete
 
 } // namespace albatross

include/albatross/src/details/traits.hpp

@@ -48,7 +48,7 @@ template <typename X> class is_complete {
   template <typename T> static std::false_type test(...);
 
 public:
-  static constexpr bool value = decltype(test<X>(0))::value;
+  static constexpr bool value = decltype(test<typename std::decay<X>::type>(0))::value;
 };
 
 template <typename T> struct is_vector : public std::false_type {};