Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scaling Functions #14

Merged
merged 2 commits into from
May 14, 2018
Merged

Scaling Functions #14

merged 2 commits into from
May 14, 2018

Conversation

akleeman
Copy link
Collaborator

Add scaling functions which provide a way of defining a covariance term which acts as a deterministic transformation of some underlying variable.

covariance term which acts as a deterministic transformation of
some underlying variable.
@akleeman akleeman force-pushed the scaling_functions branch from e013e53 to e7a7f86 Compare May 11, 2018 15:37
@akleeman akleeman requested review from kmdade and benjamin0 May 11, 2018 15:38
Copy link
Contributor

@benjamin0 benjamin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!


namespace albatross {

template <typename Term> struct CovarianceFunction {
Term covariance_term;
Term term;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: In the future, could you separate pure naming changes into another commit?

* y ~ N(0, S) with S_ij = cov(y_i, y_j)
* And you may then make observations of that random variable
* but through a known transformation,
* z = f(y) y
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like z = f(y) * y?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants