Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude Fixed Parameters #48

Merged
merged 2 commits into from
Aug 13, 2018
Merged

Exclude Fixed Parameters #48

merged 2 commits into from
Aug 13, 2018

Conversation

akleeman
Copy link
Collaborator

Make sure to exclude lower bounds when tuning using fixed parameters.

seth-swiftnav
seth-swiftnav reviewed Aug 10, 2018
View reviewed changes
Copy link
Contributor

@seth-swiftnav seth-swiftnav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

get_params_as_vector might be better named as get_tunable_params_as_vector. Since the function is designed to be used with the get_upper/lower_bounds functions, perhaps a single function which returns a struct of three equal-length vectors might be cleaner.

@akleeman
Switch to using a TunableParameter struct instead of returning
2890b2d 
vectors of doubles which should both keep the params and lower/upper
bounds consistent and make the intended use of those functions
more obvious.
@akleeman akleeman merged commit cab87fe into swift-nav:master Aug 13, 2018
@akleeman akleeman deleted the restore_is_fixed branch August 13, 2018 21:22
This was referenced Dec 13, 2022
Closed
Closed
Closed
@swiftnav-svc-jenkins swiftnav-svc-jenkins mentioned this pull request Dec 20, 2022
Closed
@swiftnav-svc-jenkins swiftnav-svc-jenkins mentioned this pull request Feb 13, 2023
Merged
@swiftnav-svc-jenkins swiftnav-svc-jenkins mentioned this pull request Jan 4, 2024
Closed
@swiftnav-svc-jenkins swiftnav-svc-jenkins mentioned this pull request Jan 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seth-swiftnav seth-swiftnav seth-swiftnav approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akleeman @seth-swiftnav