Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ESD-2257] Move archive util to common cmake repo #105

Merged
merged 4 commits into from
Nov 10, 2021
Merged

[ESD-2257] Move archive util to common cmake repo #105

merged 4 commits into from
Nov 10, 2021

Conversation

woodfell
Copy link
Contributor

This was previously implemented in a different repo and ended up being used from a different one. It really belongs here

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

jungleraptor
jungleraptor approved these changes Nov 10, 2021
View reviewed changes
Copy link
Contributor

@jungleraptor jungleraptor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What a pain that cmake doesn't provide a way to handle this out the box.

Good solution though.

@woodfell
Copy link
Contributor Author

Yep there's lot of little things that would be really nice if cmake had a built in way of doing

@woodfell woodfell merged commit 4372563 into master Nov 10, 2021
@woodfell woodfell deleted the woodfell/esd-2257/move_archive_util branch November 10, 2021 22:42
This was referenced Dec 13, 2022
Closed
Closed
Closed
@swiftnav-svc-jenkins swiftnav-svc-jenkins mentioned this pull request Dec 20, 2022
Closed
@swiftnav-svc-jenkins swiftnav-svc-jenkins mentioned this pull request Feb 13, 2023
Merged
@swiftnav-svc-jenkins swiftnav-svc-jenkins mentioned this pull request Jan 4, 2024
Closed
@swiftnav-svc-jenkins swiftnav-svc-jenkins mentioned this pull request Jan 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jungleraptor jungleraptor jungleraptor approved these changes

@RReichert RReichert Awaiting requested review from RReichert

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@woodfell @jungleraptor