Allow project wide default setting for exceptions and rtti #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woodfell
requested review from
antrikshsrivastava,
jungleraptor,
lucasle-sn and
RReichert
|
Kudos, SonarCloud Quality Gate passed!
|
antrikshsrivastava
approved these changes
Jul 8, 2022
woodfell
deleted the
woodfell/allow_project_default_for_exceptions_and_rtti
branch
This was referenced Dec 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have traditionally disabled exceptions and rtti by default across all repositories, instead relying on individual targets to turn them on as and when required.
There has come a need to have exceptions and RTTI take a default value on a project wide basis, to be controlled by some other build time config option.
This PR allows a cmake project to set the variable
${PROJECT_NAME}_EXCEPTIONS_DEFAULTand${PROJECT_NAME}_RTTI_DEFAULTto control. An individual target may still specifyEXCEPTIONS,NO_EXCEPTIONS,RTTI,NO_RTTIis there is an overriding need, this just allows a project to set a default value for all target within.