Add clang format 11 #119
Merged
Add clang format 11 #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
lkloh
reviewed
Jul 8, 2022
| @@ -212,6 +212,7 @@ function(swift_setup_clang_format) | |||
| # First try to find clang-format | |||
| if(NOT x_CLANG_FORMAT_NAMES) | |||
| set(x_CLANG_FORMAT_NAMES | |||
| clang-format11 clang-format-11 | |||
There was a problem hiding this comment.
lkloh
approved these changes
Jul 8, 2022
This was referenced Dec 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm running ubuntu and recently upgraded my clang version to match jenkins and in the process realized that cmake was still picking an older version of clang (clang-format-6.0). In this change I've added
clang-format-11as the highest priority option which (I think) aligns with the clang-format used in things like orion engine's jenkins builds.Note: I suspect we can do away with all the old versions listed in
ClangFormat.cmake, but not sure if all projects are on 11 now?