Specify header file name for non-standard installs #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
does this only affect repos that use |
|
The affected modules were unable to find dependencies from the system because of weirdly named header files. This just fixes the search for these modules, users of these packages will need to be updated with this fix but only if they are using dependencies from the system. Currently this is just piksi_apps/buildroot. Everything else uses dependencies from source and so are unaffected. |
This was referenced Dec 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some package header files can't be found automatically because they are installed to non-standard locations. By default GenericFindDependencies will search for a system header file called "lib${TARGET}/${TARGET}.h", for example the module FindSwiftnav (libswiftnav) will try to find "libswiftnav/swiftnav.h". Some packages install using a different naming scheme, libswiftnav installs "swiftnav/bits.h" (among others). This PR specifies different header file names for those packages so they can be found properly.