Add FindSwiftlets.cmake #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woodfell
reviewed
May 6, 2020
| option(pal_ENABLE_EXAMPLES "" OFF) | ||
| GenericFindDependency( | ||
| TARGET swiftlets | ||
| SOURCE_DIR swiftlets |
There was a problem hiding this comment.
This isn't strictly speaking required - GenericFindDependency searches a load of paths based on the target name to look for the submodule. It won't hurt to leave it there, it's just not required.
There was a problem hiding this comment.
I left this here as it seems to be used by quite many other modules also.
There was a problem hiding this comment.
Yeah, it's really only needed when the source code is in a directory with a different name from the target name, or when the source code is in a subdirectory in the submodule (like gnss-converters or libsbp). In this case the names as the same though
woodfell
approved these changes
May 6, 2020
RReichert
pushed a commit
that referenced
this pull request
May 13, 2020
This was referenced Dec 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.