ESD-1836: added additional massif options #59
Conversation
RReichert
changed the title
| @@ -109,6 +109,18 @@ | |||
| # | |||
| ### MASSIF SPECIFIC OPTIONS: | |||
| # | |||
| # DEPTH maximum depth of the allocation trees recorded for detailed snapshots. | |||
| # | |||
There was a problem hiding this comment.
Could you also add a unit or range to use as argument to depth?
There was a problem hiding this comment.
I did mention that the parameter expects a number and specified the default value. I've made this change to all the other single variable parameters as well.
There is no upper range within Valgrinds documentation (in my implementation it caps at 200), so I didn't want to specify the range as that isn't set in stone from the looks of things.
| # | ||
| # DETAILED_FREQUENCY frequency of detailed snapshots. With value of `1`, | ||
| # every snapshot is detailed. | ||
| # |
There was a problem hiding this comment.
Same comment as above, can I use decimal numbers as argument?
There was a problem hiding this comment.
✔️, marked it as float, the notation that is used in Valgrind of m.n seems a bit strange
There was a problem hiding this comment.
If you prefer decimal over float I can use decimal
There was a problem hiding this comment.
No, I prefer float :P looks good 👍
Not much going on in here, except just adding some extra valgrind-massif options.