Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SV4-144 update googleflags #83

Merged
merged 1 commit into from
Jun 8, 2021

Conversation

RReichert
Copy link
Contributor

@RReichert RReichert commented Jun 8, 2021

We have a forked version of gflags - https://github.com/swift-nav/gflags which recently Dennis Zollo added some commits that would remove a number of private details (see SV4-145).

With these changes, any googleflag repository that uses our forked version won't have the following entrys in the help message:

Flags from ../../../third_party/googleflags/src/gflags.cc:
    --flagfile (load flags from file) type: string default: ""
    --fromenv (set flags from the environment [use 'export FLAGS_flag1=value'])
      type: string default: ""
    --tryfromenv (set flags from the environment if present) type: string
      default: ""
    --undefok (comma-separated list of flag names that it is okay to specify on
      the command line even if the program does not define a flag with that
      name.  IMPORTANT: flags in this list that have arguments MUST use the
      flag=value format) type: string default: ""

  Flags from ../../../third_party/googleflags/src/gflags_completions.cc:
    --tab_completion_columns (Number of columns to use in output for tab
      completion) type: int32 default: 80
    --tab_completion_word (If non-empty, HandleCommandLineCompletions() will
      hijack the process and attempt to do bash-style command line flag
      completion on this value.) type: string default: ""

  Flags from ../../../third_party/googleflags/src/gflags_reporting.cc:
    --help (show help on all flags [tip: all flags can have two dashes])
      type: bool default: false currently: true
    --helpfull (show help on all flags -- same as -help) type: bool
      default: false
    --helpmatch (show help on modules whose name contains the specified substr)
      type: string default: ""
    --helpon (show help on the modules named by this flag value) type: string
      default: ""
    --helppackage (show help on all modules in the main package) type: bool
      default: false
    --helpshort (show help on only the main module for this program) type: bool
      default: false
    --helpxml (produce an xml version of help) type: bool default: false
    --version (show version and build info and exit) type: bool default: false

It also removed Flags from * which in starling currently shows our source file paths.

@RReichert RReichert force-pushed the rodrigor/SV4-144-gflags-internal-help branch from 3008f3b to cf4a429 Compare June 8, 2021 05:40
@RReichert RReichert requested a review from woodfell June 8, 2021 07:35
@RReichert RReichert merged commit 3813896 into master Jun 8, 2021
@RReichert RReichert deleted the rodrigor/SV4-144-gflags-internal-help branch June 8, 2021 22:21
@RReichert RReichert restored the rodrigor/SV4-144-gflags-internal-help branch June 9, 2021 03:24
@RReichert RReichert deleted the rodrigor/SV4-144-gflags-internal-help branch June 9, 2021 03:24
woodfell added a commit that referenced this pull request Jun 29, 2021
* SV4-144 update googleflags (#83)

* scripts: Fix flakes

`sys` was unused.
Also tabs were used in memcheck_xml2junit_converter.py

* memcheck_xml2junit_converter.py: Remove redundancy

SonarCloud complains about the repeated string.

Co-authored-by: Rodrigo Reichert <[email protected]>
Co-authored-by: John Vandenberg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants