Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote FileIO to Stable #175

Closed
mfine opened this issue Jun 19, 2015 · 5 comments
Closed

Promote FileIO to Stable #175

mfine opened this issue Jun 19, 2015 · 5 comments
Assignees

Comments

@mfine
Copy link
Contributor

mfine commented Jun 19, 2015

To reach SBP version 1.0, we should promote the file_io messages to stable:

MSG_FILEIO_READ
MSG_FILEIO_READ_DIR
MSG_FILEIO_REMOVE
MSG_FILEIO_WRITE

Insure their form and fitness for stability. In particular, remove bi-direction from these message. Presently,

FILEIO_READ
FILEIO_READ_DIR
FILEIO_WRITE

are bi-directional and confusing to use - we should introduce directionality:

FILEIO_READ_DEVICE
FILEIO_READ_HOST
FILEIO_READ_DIR_DEVICE
FILEIO_READ_DIR_HOST
FILEIO_WRITE_DEVICE
FILEIO_WRITE_HOST

/cc @mookerji @fnoble @cbeighley @denniszollo

@mookerji
Copy link
Contributor

I'm all for fixing the request/response format here and possibly their payload specs, but don't feel great about making them stable, if only because they're really intended for internal use.

@denniszollo
Copy link
Contributor

One question about FILEIO_WRITE_HOST. I assume that this msg will be a confirmation message that the file was written (ie number of bytes), or an error string?

Additionally, might we consider allowing the piksi to log out information to another piksi or PC via these messages? Or are we saying that these messages are strictly for writing to or reading from a Piksi's flash from a host?

@mfine mfine self-assigned this Jun 22, 2015
@mfine
Copy link
Contributor Author

mfine commented Jun 22, 2015

Won't promote these to stable.

Not sure what the scope is for returning errors. There is precedence for returning _DONE here.

@cbeighley cbeighley modified the milestone: Sprint Ending 7/3 Jun 22, 2015
@mfine
Copy link
Contributor Author

mfine commented Jun 22, 2015

Completion criteria: new non-directional messages laid out.

@mfine
Copy link
Contributor Author

mfine commented Jun 24, 2015

Pull requests capturing this work:

#183
swift-nav/piksi_tools#84
swift-nav/piksi_firmware#452

@imh imh removed the 5 - Done label Jul 20, 2015
reimerix pushed a commit that referenced this issue Sep 11, 2024
… [AP-1823] (#175) (#1418)

Automated PR by Jenkins. If CI has passed successfully, merge away!



**cmake**  68306be8  ->  65c9a396
- 65c9a396 : Update compiler options to support IAR [AP-1823]
(swift-nav/cmake#175)


This pull request was created by
https://jenkins.ci.swift-nav.com/job/CI%20Infra/job/submodule-update/18067/.


[AP-1823]:
https://swift-nav.atlassian.net/browse/AP-1823?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants