Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix kaitai py tests #1410

Merged
merged 4 commits into from
Apr 5, 2024
Merged

Fix kaitai py tests #1410

merged 4 commits into from
Apr 5, 2024

Conversation

woodfell
Copy link
Contributor

@woodfell woodfell commented Apr 3, 2024

Description

@swift-nav/devinfra

API compatibility

Does this change introduce a API compatibility risk?

API compatibility plan

If the above is "Yes", please detail the compatibility (or migration) plan:

JIRA Reference

https://swift-nav.atlassian.net/browse/BOARD-XXXX

Makefile Outdated
@@ -427,6 +427,7 @@ test-protobuf:
$(call announce-begin,"Running Protocol Buffer tests")
$(call announce-end,"Finished running Protocol Buffer tests")

# remove me
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will be removed before merging, only here to force the Docker CI Stage to run

@woodfell woodfell marked this pull request as ready for review April 4, 2024 05:59
@woodfell woodfell requested a review from a team as a code owner April 4, 2024 05:59
@woodfell woodfell requested a review from dgburr April 4, 2024 06:00
@dgburr
Copy link
Contributor

dgburr commented Apr 4, 2024

For future readers: this breakage was introduced in #1400

Copy link
Contributor

@dgburr dgburr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@woodfell woodfell enabled auto-merge (squash) April 4, 2024 22:43
Copy link

sonarqubecloud bot commented Apr 4, 2024

Quality Gate Passed Quality Gate passed for 'libsbp-c'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor

@pcrumley pcrumley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@woodfell woodfell merged commit faba77a into master Apr 5, 2024
7 checks passed
@woodfell woodfell deleted the woodfell/fix_kaitai_py_tests branch April 5, 2024 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants