Version available in c #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test PASSed. |
|
What do you mean by "change?" |
|
Since the version is generated, there can be races to get versions in (I do v16 you do v16, then we merge, etc.). Also we need to manually upkeep this as versions change. Not the end of the world, but something to keep an idea about. Maybe there's a better way to do this? |
|
lgtm |
silverjam
pushed a commit
that referenced
this pull request
Jun 13, 2023
…cific (#158) (#1341) Automated PR by Jenkins. If CI has passed successfully, merge away! **cmake** 12b7f037 -> 04c7c144 - 04c7c144 : fix: make test_srcs target project specific (swift-nav/cmake#158) This pull request was created by https://jenkins.ci.swift-nav.com/job/CI%20Infra/job/submodule-update/14394/.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is what I got for getting a c header version. Not great (you have to choose the version ahead of time, which might change by the time you finally bring it in). But oh well.
/cc @mookerji @cbeighley