Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix changing rgb and hsv when changing hex #45

Merged

Conversation

raqso
Copy link
Contributor

@raqso raqso commented Jun 9, 2020

Fix for #46
Set rgb and hsv when hex change

@codecov-commenter
Copy link

Codecov Report

Merging #45 into master will decrease coverage by 0.95%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #45      +/-   ##
==========================================
- Coverage   30.64%   29.68%   -0.96%     
==========================================
  Files           3        3              
  Lines          62       64       +2     
  Branches        4        4              
==========================================
  Hits           19       19              
- Misses         40       42       +2     
  Partials        3        3              
Impacted Files Coverage Δ
src/color-picker.js 9.09% <0.00%> (-0.44%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b26236...ee76275. Read the comment docs.

@wangzuo wangzuo merged commit f086a0a into swiftcarrot:master Jul 29, 2020
@wangzuo
Copy link
Collaborator

wangzuo commented Jul 29, 2020

Thanks!

@raqso raqso deleted the fix/changing-hex-input-doesnt-update-color branch September 6, 2020 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants