[Xcodeproj] Add support for automatic project generation #1604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a `--watch` option to generate-xcodeproj subcommand. SwiftPM will do the necessary configuration and exec to the watchman-make tool. If the tool can't be found on the system, it'll emit help information to install it. <rdar://problem/32390792> Add support for automatically maintaining the generated Xcode project
|
@swift-ci please smoke test |
hartbit
reviewed
Jun 16, 2018
| @@ -195,7 +195,7 @@ public final class Process: ObjectIdentifierProtocol { | |||
| /// Returns true if the given program is present and executable in search path. | |||
There was a problem hiding this comment.
We probably want to update to documentation to say a path is returned.
hartbit
reviewed
Jun 16, 2018
| option: "--legacy-scheme-generator", kind: Bool.self, | ||
| usage: "Use the legacy scheme generator"), | ||
| generateXcodeParser.add( | ||
| option: "--watch", kind: Bool.self, | ||
| usage: "Watch the filesystem and autogenerate the Xcode project if needed"), |
There was a problem hiding this comment.
Would it be worth being more specific?
Watch for changes to the Package manifest to regenerate the Xcode project
hartbit
reviewed
Jun 16, 2018
| name: "org.swift.diags.watchman-missing", | ||
| description: { | ||
| $0 <<< "this feature requires 'watchman' to work" | ||
| $0 <<< "\n\n installation instructions for 'watchman' are available at https://facebook.github.io/watchman/docs/install.html#buildinstall" |
There was a problem hiding this comment.
Looks a bit "pretty".
hartbit
reviewed
Jun 16, 2018
|
|
||
| set -eu | ||
|
|
||
| swift package generate-xcodeproj |
There was a problem hiding this comment.
Do we also want a test that makes such that we pass --xcconfig-overrides when necessary?
aciidgh
added a commit
to aciidgh/swift-package-manager
that referenced
this pull request
Jun 19, 2018
aciidgh
added a commit
that referenced
this pull request
Jun 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
--watchoption to generate-xcodeproj subcommand. SwiftPMwill do the necessary configuration and exec to the watchman-make tool.
If the tool can't be found on the system, it'll emit help information to
install it.
rdar://problem/32390792 Add support for automatically maintaining the generated Xcode project