Allow for .package(url: String, revision: String) syntax #3310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also includes updated tests, and documentation
miggs597
requested review from
abertelrud,
friedbunny,
neonichu and
tomerd
as code owners
neonichu
approved these changes
Feb 25, 2021
|
@swift-ci please smoke test |
tomerd
added
the
ready
|
@swift-ci please smoke test |
|
@swift-ci please smoke test |
1 similar comment
|
@swift-ci please smoke test |
abertelrud
reviewed
Feb 26, 2021
abertelrud
reviewed
Feb 26, 2021
| @@ -81,7 +81,24 @@ extension Package.Dependency { | |||
| ) -> Package.Dependency { | |||
| return .init(name: name, url: url, requirement: .branch(branch)) | |||
| } | |||
|
|
|||
|
|
|||
| /// Adds a remote package dependency given a branch requirement. | |||
There was a problem hiding this comment.
Should this say revision?
abertelrud
reviewed
Feb 27, 2021
Documentation/PackageDescription.md
Outdated
| @@ -306,6 +306,16 @@ static func package(url: String, _ requirement: Package.Dependency.Requirement) | |||
| /// - branch: A dependency requirement. See static methods on `Package.Dependency.Requirement` for available options. | |||
| static func package(name: String? = nil, url: String, branch: String) -> Package.Dependency | |||
|
|
|||
| /// Adds a remote package dependency given a branch requirement. | |||
There was a problem hiding this comment.
Should this say revision?
There was a problem hiding this comment.
Yeah you're right, thanks for catching that
|
@swift-ci please smoke test |
added 2 commits
March 1, 2021 12:07
As it's intended for a next version of Package Description
|
@swift-ci please smoke test |
|
@swift-ci please smoke test |
tomerd
approved these changes
Mar 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just adding the convenience init .package(url: String, revision: String)