cache binary artifact globally #7101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
motivation: like other dependencies, binary artifacts are good candidates for user level caching such that they do not need to be re-downloaded changes: * update BinaryArtifactsManager to take cache path and use the cache to store binary artifacts when downloading them * update test infra to enable/disable artifacts caching * update workspaace call sites * update workspace delegate to indicate when using cached binary artifact * update and add tests rdar://111774147
|
@swift-ci test |
MaxDesiatov
reviewed
Nov 16, 2023
MaxDesiatov
reviewed
Nov 16, 2023
MaxDesiatov
reviewed
Nov 16, 2023
Co-authored-by: Max Desiatov <[email protected]>
Co-authored-by: Max Desiatov <[email protected]>
|
@swift-ci test |
|
@swift-ci test windows |
MaxDesiatov
approved these changes
Nov 22, 2023
tomerd
added a commit
to tomerd/swift-package-manager
that referenced
this pull request
Nov 30, 2023
motivation: like other dependencies, binary artifacts are good candidates for user level caching such that they do not need to be re-downloaded changes: * update BinaryArtifactsManager to take cache path and use the cache to store binary artifacts when downloading them * update test infra to enable/disable artifacts caching * update workspaace call sites * update workspace delegate to indicate when using cached binary artifact * update and add tests rdar://111774147
tomerd
added a commit
that referenced
this pull request
Nov 30, 2023
motivation: make sure changelog reflects key changes changes: mention caching of binary artifacts per #7101
Merged
tomerd
added a commit
that referenced
this pull request
Nov 30, 2023
motivation: make sure changelog reflects key changes changes: mention caching of binary artifacts per #7101
tomerd
added a commit
that referenced
this pull request
Dec 1, 2023
motivation: like other dependencies, binary artifacts are good candidates for user level caching such that they do not need to be re-downloaded changes: * update BinaryArtifactsManager to take cache path and use the cache to store binary artifacts when downloading them * update test infra to enable/disable artifacts caching * update workspaace call sites * update workspace delegate to indicate when using cached binary artifact * update and add tests rdar://111774147
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motivation: like other dependencies, binary artifacts are good candidates for user level caching such that they do not need to be re-downloaded
changes:
rdar://111774147