Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mark several FileSystem APIs as disfavored overloads #418

Merged
merged 1 commit into from
May 2, 2023

Conversation

tomerd
Copy link
Contributor

@tomerd tomerd commented May 2, 2023

motivation: help the transition off of TSC Path and FileSystem

changes:

  • mark several FileSystem APIs that return AbsolutePath as disfavored overloads
  • deprecate Product which is really a SwiftPM construct

Copy link
Contributor

@MaxDesiatov MaxDesiatov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the intention to migrate these to System.FilePath eventually?

@tomerd
Copy link
Contributor Author

tomerd commented May 2, 2023

yes, but in multiple steps. this is step 0

@tomerd
Copy link
Contributor Author

tomerd commented May 2, 2023

@swift-ci test

@tomerd
Copy link
Contributor Author

tomerd commented May 2, 2023

@swift-ci test windows

motivation: help the transition off of TSC Path and FileSystem

changes:
* mark several FileSystem APIs that return AbsolutePath as disfavored overloads
* deprecate Product which is really a SwiftPM construct
@tomerd
Copy link
Contributor Author

tomerd commented May 2, 2023

@swift-ci test

@tomerd
Copy link
Contributor Author

tomerd commented May 2, 2023

@swift-ci test windows

@tomerd tomerd enabled auto-merge (squash) May 2, 2023 17:18
@tomerd
Copy link
Contributor Author

tomerd commented May 2, 2023

@swift-ci test windows

@tomerd tomerd merged commit ee4cb5e into swiftlang:main May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants