Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.10] Fix filesystem test on macOS #466

Merged
merged 1 commit into from
May 4, 2024
Merged

[5.10] Fix filesystem test on macOS #466

merged 1 commit into from
May 4, 2024

Conversation

MaxDesiatov
Copy link
Contributor

@MaxDesiatov MaxDesiatov commented Feb 5, 2024 •
edited
Loading

  • Explanation: It looks like we end up with EEXISTS here on newer versions of macOS.
  • Scope: Any test runs on macOS will fail because of this issue.
  • Risk: Low, it doesn't impact existing file system error handling.
  • Testing: This new file system error case is specifically handled in tests.
  • Reviewer: @neonichu
  • Main branch PR: Fix filesystem test on macOS #460

@neonichu @MaxDesiatov
Fix filesystem test on macOS
2828464 
It looks like we end up with `EEXISTS` here on newer versions of macOS.
@MaxDesiatov MaxDesiatov changed the title Fix filesystem test on macOS [5.10] Fix filesystem test on macOS Feb 5, 2024
@MaxDesiatov MaxDesiatov added the swift 5.10 This PR targets the 5.10 branch label Feb 5, 2024
@MaxDesiatov
Copy link
Contributor Author

#461 was merged to main by mistake, this one has release/5.10 branch set as base.

@MaxDesiatov
Copy link
Contributor Author

@swift-ci test

@finagolfin finagolfin mentioned this pull request Feb 15, 2024
Merged
@finagolfin
Copy link
Member

This can be merged?

@shahmishal shahmishal merged commit 80d8813 into release/5.10 May 4, 2024
3 checks passed
@shahmishal shahmishal deleted the fix-tests-on-macos-5.10 branch May 4, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@airspeedswift airspeedswift airspeedswift approved these changes

@abertelrud abertelrud Awaiting requested review from abertelrud abertelrud is a code owner

@neonichu neonichu Awaiting requested review from neonichu neonichu is a code owner

@tomerd tomerd Awaiting requested review from tomerd

@bnbarham bnbarham Awaiting requested review from bnbarham

Assignees
No one assigned
Labels
bug swift 5.10 This PR targets the 5.10 branch test suite
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MaxDesiatov @finagolfin @airspeedswift @shahmishal @neonichu