[cxx-interop] Add -cxx-interoperability-mode driver flag; deprecate `-…
#64088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
zoecarver
commented
Mar 4, 2023
lib/Frontend/CompilerInvocation.cpp
Outdated
| static CxxCompatMode validateCxxInteropCompatibilityMode(StringRef mode) { | ||
| if (mode == "off") | ||
| return CxxCompatMode::off; | ||
| if (mode == "swift-5.7") |
There was a problem hiding this comment.
Suggested change
| if (mode == "swift-5.7") | |
| if (mode == "swift-5.9") |
And similar
…enable-experimental-cxx-interop`.
zoecarver
requested review from
hyp,
egorzhdan,
artemcm,
hborla,
slavapestov and
xedin
as code owners
zoecarver
force-pushed
the
cxx-compatibility-mode
branch
from
804be33 to
f2a36ee
Compare
|
@swift-ci please smoke test |
|
Once swiftlang/swift-driver#1306 lands I'll make another patch to update the tests in this repo. |
artemcm
reviewed
Mar 7, 2023
|
@swift-ci please smoke test |
zoecarver
changed the title
-cxx-compatibility-mode driver flag; deprecate `-…-cxx-interoperability-mode driver flag; deprecate `-…
zoecarver
commented
Mar 7, 2023
| @@ -32,15 +32,9 @@ module CxxTest { | |||
| Add the C++ module to the include path and enable C++ interop: | |||
| - Navigate to your project directory | |||
| - In `Project` navigate to `Build Settings` -> `Swift Compiler` | |||
| - Under `Custom Flags` -> `Other Swift Flags` add `-Xfrontend -enable-experimental-cxx-interop` | |||
| - Under `Custom Flags` -> `Other Swift Flags` add `-cxx-compatibility-mode=swift-5.9` | |||
There was a problem hiding this comment.
Suggested change
| - Under `Custom Flags` -> `Other Swift Flags` add `-cxx-compatibility-mode=swift-5.9` | |
| - Under `Custom Flags` -> `Other Swift Flags` add `-cxx-interoperability-mode=swift-5.9` |
Looks like this one got lost in the rebase.. oops
zoecarver
added a commit
that referenced
this pull request
Mar 8, 2023
zoecarver
added a commit
that referenced
this pull request
Mar 9, 2023
Follow up from #64088: compatibility -> interoperability
egorzhdan
added a commit
to swiftlang/swift-package-manager
that referenced
this pull request
Mar 15, 2023
This adds a build setting to the package manifest that enables Swift/C++ Interoperability for a given Swift target: ``` .interoperabilityMode(.Cxx, version: "swift-5.9") ``` This relies on the new Swift driver flag for versioned C++ interop (see swiftlang/swift#64088). rdar://106756067
egorzhdan
added a commit
to swiftlang/swift-package-manager
that referenced
this pull request
Mar 16, 2023
This adds a build setting to the package manifest that enables Swift/C++ Interoperability for a given Swift target: ``` .interoperabilityMode(.Cxx, version: "swift-5.9") ``` This relies on the new Swift driver flag for versioned C++ interop (see swiftlang/swift#64088). rdar://106756067
egorzhdan
added a commit
to swiftlang/swift-package-manager
that referenced
this pull request
Mar 16, 2023
This adds a build setting to the package manifest that enables Swift/C++ Interoperability for a given Swift target: ``` .interoperabilityMode(.Cxx, version: "swift-5.9") ``` This relies on the new Swift driver flag for versioned C++ interop (see swiftlang/swift#64088). rdar://106756067
zoecarver
pushed a commit
to swiftlang/swift-package-manager
that referenced
this pull request
Mar 16, 2023
This adds a build setting to the package manifest that enables Swift/C++ Interoperability for a given Swift target: ``` .interoperabilityMode(.Cxx, version: "swift-5.9") ``` This relies on the new Swift driver flag for versioned C++ interop (see swiftlang/swift#64088). rdar://106756067
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…enable-experimental-cxx-interop`.
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves #NNNNN, fix apple/llvm-project#MMMMM.