PackageCMO: fix serializability check for keypath #78732
+187
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci smoke test |
elsh
force-pushed
the
elsh/pcmo-keypath-fix
branch
from
54b7b76 to
8cd8e5b
Compare
|
@swift-ci smoke test |
When a keypath instruction was checked for serializability, its referenced function was sometimes incorrectly deemed serializable when its referenced method had package or public access level. This resulted in incorrectly serializing a function that dynamically accesses a property on a generic type using key path. This PR fixes the issue by skipping the access level check if the referenced function is determined to be un-serializable. Resolves rdar://142950306
elsh
force-pushed
the
elsh/pcmo-keypath-fix
branch
from
b35b7e6 to
83f1ff6
Compare
|
@swift-ci smoke test |
eeckstein
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a keypath instruction was checked for serializability, its referenced function was
sometimes incorrectly deemed serializable when its referenced method had package or
public access level. This resulted in incorrectly serializing a function that dynamically
accesses a property on a generic type using key path. This PR fixes the issue by skipping
the access level check if the referenced function is determined to be un-serializable.
Resolves rdar://142950306