refactor(cli): return errors

swordev · Sep 25, 2023 · 4db934c · 4db934c
1 parent d87e1c4
commit 4db934c
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 8 deletions.
diff --git a/packages/cli/src/Action/BackupAction.ts b/packages/cli/src/Action/BackupAction.ts
@@ -294,7 +294,7 @@ export class BackupAction<TRequired extends boolean = true> {
 
   async exec(session: BackupSessionManager) {
     const [snapshot, packages] = await this.init(session);
-    let errors = 0;
+    const errors: Error[] = [];
 
     for (const pkg of packages) {
       const id = session.findId({
@@ -363,7 +363,7 @@ export class BackupAction<TRequired extends boolean = true> {
 
       const error = this.getError(pkg);
 
-      if (error) errors++;
+      if (error) errors.push(error);
       await session.end({
         id: id,
         error: error?.message,
@@ -376,7 +376,7 @@ export class BackupAction<TRequired extends boolean = true> {
 
     return {
       total: packages.length,
-      errors: errors,
+      errors,
     };
   }
 }
diff --git a/packages/cli/src/Action/RestoreAction.ts b/packages/cli/src/Action/RestoreAction.ts
@@ -315,7 +315,7 @@ export class RestoreAction<TRequired extends boolean = true> {
 
     await this.init(session, this.options.snapshotId, snapshotAndConfigs);
 
-    let sessionErrors = 0;
+    const errors: Error[] = [];
 
     for (const [snapshot, pkg] of snapshotAndConfigs) {
       ok(pkg);
@@ -363,10 +363,10 @@ export class RestoreAction<TRequired extends boolean = true> {
         id,
         error: error?.message,
       });
-      if (error) sessionErrors++;
+      if (error) errors.push(error);
     }
 
     await session.endDrivers();
-    return !sessionErrors;
+    return { errors };
   }
 }
diff --git a/packages/cli/src/Command/BackupCommand.ts b/packages/cli/src/Command/BackupCommand.ts
@@ -89,7 +89,7 @@ export class BackupCommand extends CommandAbstract<
     });
 
     const result = await backup.exec(sessionManager);
-    if (result.errors) {
+    if (result.errors.length) {
       return 1;
     } else if (!result.total) {
       throw new AppError("None package config found");

diff --git a/packages/cli/src/Command/RestoreCommand.ts b/packages/cli/src/Command/RestoreCommand.ts
@@ -90,6 +90,6 @@ export class RestoreCommand extends CommandAbstract<
 
     const result = await restore.exec(sessionManager);
 
-    return result ? 0 : 1;
+    return result.errors.length ? 0 : 1;
   }
 }