Convert initialization action for time to mutator #4513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wthrowe
previously approved these changes
Dec 14, 2022
| /// and `Tags::Next<Tags::TimeStepId>` is the initial time. | ||
| template <typename Metavariables, bool UsingLts> | ||
| struct TimeStepping { | ||
| using time_stepper_t = |
There was a problem hiding this comment.
[optional] This is a "traditional" type alias, not a metavariable, so should be camel case.
There was a problem hiding this comment.
I will do this change now
nilsdeppe
previously approved these changes
Dec 15, 2022
| /// Since the evolution has not started yet, initialize the state | ||
| /// _before_ the initial time. So `Tags::TimeStepId` is undefined at this point, | ||
| /// and `Tags::Next<Tags::TimeStepId>` is the initial time. | ||
| template <typename Metavariables, bool UsingLts> |
There was a problem hiding this comment.
We could also pass in the step_chooser_simple_tags directly instead of the Metavariables, but I'm totally fine doing that later in order to get this merge :)
There was a problem hiding this comment.
I will do something later when I deal with step_chooser_compute_tags (which are now handled by calling AddComputeItems, but should be able to just add them to one of the initialization mutators)
kidder
force-pushed
the
initialize_time_step
branch
from
4f28b96 to
a71e3df
Compare
nilsdeppe
previously approved these changes
Dec 15, 2022
kidder
force-pushed
the
initialize_time_step
branch
from
a71e3df to
95def92
Compare
nilsdeppe
approved these changes
Dec 16, 2022
wthrowe
approved these changes
Dec 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Upgrade instructions
Code review checklist
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.
bugfixornew featureif appropriate.Further comments