Fix bug in rootfind for enthalpy parametrization #4536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isaaclegred
added
the
small
nilsdeppe
requested changes
Dec 20, 2022
| @@ -14,7 +14,7 @@ | |||
| #include "PointwiseFunctions/Hydro/EquationsOfState/Factory.hpp" | |||
| #include "PointwiseFunctions/Hydro/SpecificEnthalpy.hpp" | |||
| #include "Utilities/ErrorHandling/Error.hpp" | |||
| #include "Utilities/MakeWithValue.hpp" | |||
| #include "Utilities/MakeWithValue.hpp | |||
isaaclegred
force-pushed
the
enthalpy_bugfix
branch
from
82e8b97 to
2df1957
Compare
nilsdeppe
approved these changes
Dec 20, 2022
nilsvu
previously requested changes
Dec 20, 2022
Comment on lines
+163
to
+164
| // Guarantee that the root find has the correct bracket by explicitly | ||
| // nonsensical there, so if the correct braket |
There was a problem hiding this comment.
We need this merged ASAP because we are doing large simulations on Wheeler over the break. I think the sentence, while not great, is clear enough that it would be better for our science purposes to not delay this PR. Given some folks (including myself) are already on vacation and only doing this that are needed to do simulations over the break, I'd like to not block this PR on the sentence...
There was a problem hiding this comment.
Just FYI, as a reminder: #4537
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Change the limits for rootfind in computing density as a function of specific enthalpy
Upgrade instructions
Code review checklist
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.
bugfixornew featureif appropriate.Further comments