Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase Test_BinaryCompactObject timeout #4579

Merged
merged 1 commit into from
Jan 11, 2023

Conversation

nilsdeppe
Copy link
Member

Proposed changes

This keeps timing out in develop. Unclear how easy it is to speed up the test, that would be ideal at this point.

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

This keeps timing out in develop. Unclear how easy it is to speed up the test,
that would be ideal at this point.
@nilsdeppe nilsdeppe added the small Only changes a few lines of code, does a rename or is otherwise quick to review label Jan 11, 2023
@nilsvu nilsvu enabled auto-merge January 11, 2023 07:21
@nilsvu nilsvu merged commit b4d3530 into sxs-collaboration:develop Jan 11, 2023
@nilsdeppe nilsdeppe deleted the bco_timeout branch September 14, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
small Only changes a few lines of code, does a rename or is otherwise quick to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants