Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TBC: Replace PARTY_MEMBERS_CHANGED with GROUP_ROSTER_UPDATE in PlayerNames.lua #226

Open
mburger-scheidlin opened this issue Jun 22, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@mburger-scheidlin
Copy link

mburger-scheidlin commented Jun 22, 2021

I got the following error. Changing "PARTY_MEMBERS_CHANGED" to "GROUP_ROSTER_UPDATE" in PlayerNames.lua:1132 fixed this. The reference to attune is misleading at first, I think this is just because it loaded AceEvent first.
See https://wowpedia.fandom.com/wiki/PARTY_MEMBERS_CHANGED

Message: ...ace\AddOns\Attune\Libs\AceEvent-3.0\AceEvent-3.0.lua:33: Attempt to register unknown event "PARTY_MEMBERS_CHANGED"
Count: 1
Stack: ...ace\AddOns\Attune\Libs\AceEvent-3.0\AceEvent-3.0.lua:33: Attempt to register unknown event "PARTY_MEMBERS_CHANGED"
[string "=(tail call)"]: ?
[string "=[C]"]: in function RegisterEvent' [string "@Interface\AddOns\Attune\Libs\AceEvent-3.0\AceEvent-3.0.lua"]:33: in function OnUsed'
[string "@interface\AddOns\Atlas\Libs\CallbackHandler-1.0\CallbackHandler-1.0.lua"]:142: in function RegisterEvent' **[string "@Interface\AddOns\Prat-3.0\modules\PlayerNames.lua"]:1132: in function OnModuleEnable'**
[string "@interface\AddOns\Prat-3.0\addon\modules.lua"]:189: in function <Interface\AddOns\Prat-3.0\addon\modules.lua:178>
[string "=[C]"]: ?
[string "@interface\AddOns\Atlas\Libs\AceAddon-3.0\AceAddon-3.0.lua"]:70: in function <...face\AddOns\Atlas\Libs\AceAddon-3.0\AceAddon-3.0.lua:65>
[string "@interface\AddOns\Atlas\Libs\AceAddon-3.0\AceAddon-3.0.lua"]:527: in function EnableAddon' [string "@Interface\AddOns\Atlas\Libs\AceAddon-3.0\AceAddon-3.0.lua"]:540: in function EnableAddon'
[string "@interface\AddOns\Atlas\Libs\AceAddon-3.0\AceAddon-3.0.lua"]:630: in function <...face\AddOns\Atlas\Libs\AceAddon-3.0\AceAddon-3.0.lua:615>

Locals:

@mburger-scheidlin mburger-scheidlin added the bug Something isn't working label Jun 22, 2021
@Road-block
Copy link

Pull request #220 and test packages provided at the last comment have this (and a bunch of other stuff) fixed.

@meflakcannon
Copy link

This has been fixed a few times in several branches (Check branches). However due to the passing of Sylvanaar. The merges won't be approved to the main files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants