BCC compatibility + some older problem fixes. #220

Road-block · 2021-05-24T23:58:33Z

BCC compatibility is a side-effect from a bunch of dead code fixes.

Commit messages have the details.

replace dead code for group scaching in playernames module add a sanity check for toast button in originalbuttons module

Road-block · 2021-05-25T00:06:44Z

This supercedes #218 #214 completely, and #211 partially. It does not include the chat bubble border coloring fix.

Road-block · 2021-05-25T07:50:14Z

So.. I'm going to leave it alone for now.
With the last commits it can close #218 , #214 and #211

I tried to keep things nice and separate in different commits rather than a big one so they can be cherry picked as needed.

Road-block · 2021-05-25T12:54:32Z

This should also close #219 #206 #202 and #221

refactor backdrop compatibility for bcc and classic era

Road-block · 2021-05-27T18:11:38Z

New package for testing.

Prat-3.0-3.9.1-5-571c1f6-bc.zip

Download, extract in AddOns, answer Yes to any overwrite prompts.

Daeveren · 2021-05-28T22:26:58Z

New package for testing.

Prat-3.0-3.9.1-3-085c8d7-bc.zip

Download, extract in AddOns, answer Yes to any overwrite prompts.

The scrolldown button no longer appears when I scroll chat to see old messages (display > buttons > show scrolldown reminder)

Road-block · 2021-05-28T22:36:44Z

New package for testing.
Prat-3.0-3.9.1-3-085c8d7-bc.zip
Download, extract in AddOns, answer Yes to any overwrite prompts.

The scrolldown button no longer appears when I scroll chat to see old messages (display > buttons > show scrolldown reminder)

What version of the game (BCC, Classic Era)?
Was it working with a previous Prat version? On what version of the game was it working if yes.
Is it with OriginalButtons module enabled or not?

ConKou · 2021-05-29T10:26:29Z

Is there any way to make it so that WoWUp and other addon managers, can auto-detect files from PRs and update automatically? Because unless we do it manually, they still see Prat as a classic addon and issue a warning

Road-block · 2021-05-29T16:02:02Z

Is there any way to make it so that WoWUp and other addon managers, can auto-detect files from PRs and update automatically? Because unless we do it manually, they still see Prat as a classic addon and issue a warning

There are workarounds for WowUp and Ajour (not sure about Overwolf client) to point it to a new repository for updates.
I know some people close to Sylvanaar are trying to figure out a way to hand over the project so it can continue but that will take some time.

I could probably keep Prat going for Classic Era / BCC but I do not play retail, nor do I intend to in the future so I will not be involved in maintaining the addon going forward.
It also has a huge install base and that's more "work" to support it than I'm willing to give.

TL;DR: Wait for a new main repository to show up or the project to be handed over.
In the mean-time you could use WowUp's Install from URL and point it to this tag
https://github.com/Road-block/prat-3-0/releases/latest

for BCC

Daeveren · 2021-05-29T19:07:28Z

New package for testing.
Prat-3.0-3.9.1-3-085c8d7-bc.zip
Download, extract in AddOns, answer Yes to any overwrite prompts.

The scrolldown button no longer appears when I scroll chat to see old messages (display > buttons > show scrolldown reminder)

What version of the game (BCC, Classic Era)?
Was it working with a previous Prat version? On what version of the game was it working if yes.
Is it with OriginalButtons module enabled or not?

In BCC it doesn't show the button. I only noticed this now installed your fork few days ago (before that I was using the normal addon, with some fixes from Curse comments).

ConKou · 2021-05-29T22:29:43Z

New package for testing.
Prat-3.0-3.9.1-3-085c8d7-bc.zip
Download, extract in AddOns, answer Yes to any overwrite prompts.

The scrolldown button no longer appears when I scroll chat to see old messages (display > buttons > show scrolldown reminder)

What version of the game (BCC, Classic Era)?
Was it working with a previous Prat version? On what version of the game was it working if yes.
Is it with OriginalButtons module enabled or not?

In BCC it doesn't show the button. I only noticed this now installed your fork few days ago (before that I was using the normal addon, with some fixes from Curse comments).

Its a thing with OriginalButton and Buttons Modules. Play around with them and you will find the fix. Happened to me as well, had to reload them one by one for it to work in the end

Daeveren · 2021-05-30T00:04:36Z

Only when I disabled Buttons and enabled Original Buttons I got the original up/down and Scrooldown buttons, but that's not what I wanted (and that disables the Buttons section in the Prat options completely). I didn't managed to make the Scrolldown button load from the Buttons module.
So far testing each of the buttons in the Buttons category goes like this:

show arrows - works
show social menu - does nothing
show minimize button - does nothing
show channel button - works
show scrolldown reminder - does nothing
show menu - works
show voice buttons - does nothing.

Road-block · 2021-05-30T00:16:04Z

Only when I disabled Buttons and enabled Original Buttons I got the original up/down and Scrooldown buttons, but that's not what I wanted (and that disables the Buttons section in the Prat options completely). I didn't managed to make the Scrolldown button load from the Buttons module.
So far testing each of the buttons in the Buttons category goes like this:

show arrows - works

show social menu - does nothing

show minimize button - does nothing

show channel button - works

show scrolldown reminder - does nothing

show menu - works

show voice buttons - does nothing.

I'll take a look when I find some time but if I'm honest I did not touch anything related to those modules (other than fixing a bug in OriginalButtons module) so I doubt this is a new bug.
Probably default UI has changed and Prat has not followed those changes.

ConKou · 2021-05-31T08:32:58Z

small thing, in colored chat bubbles there is the little part where the bubble starts that doesnt get colored

Road-block · 2021-05-31T21:00:51Z

New package with minor fix for bubble coloring. Prat-3.0-3.9.1-5-571c1f6-bc.zip

watchout-mods · 2021-05-31T21:38:35Z

@Road-block Oh nice, I didn't get a notification for this, bad github! I see you're much more invested in maintaining Prat :)

@KonstantinosKoubetsos I think the tail was never coloured in prat, or at least when I updated the code in my PR, it seemed so

ConKou · 2021-06-01T17:24:57Z

@Road-block thanks for the tail fix
Im noticing on WoW Interface its updated to the bcc libraries and picked up by WoW Up
https://www.wowinterface.com/downloads/info10783#other
Is that you with the same file commits as here?

Road-block · 2021-06-01T17:46:49Z

@Road-block thanks for the tail fix
Im noticing on WoW Interface its updated to the bcc libraries and picked up by WoW Up
https://www.wowinterface.com/downloads/info10783#other
Is that you with the same file commits as here?

It is.

ConKou · 2021-06-01T17:48:56Z

@Road-block thanks for the tail fix
Im noticing on WoW Interface its updated to the bcc libraries and picked up by WoW Up
https://www.wowinterface.com/downloads/info10783#other
Is that you with the same file commits as here?

It is.

That's great. So i can just change providers and monitor from WoW Interface

ConKou · 2021-06-01T17:54:47Z

@Road-block weird thing, i just installed from WoW Interface and colored bubbles stopped working all together. I have no color at all. I checked your commit and the lines of code are not existant on the file.

Road-block · 2021-06-01T18:05:06Z

@Road-block weird thing, i just installed from WoW Interface and colored bubbles stopped working all together. I have no color at all. I checked your commit and the lines of code are not existant on the file.

I just downloaded manually to check I uploaded the correct package and I did.
It's possible your updater is picking the main addon rather than the patched one.
https://www.wowinterface.com/downloads/info26044

ConKou · 2021-06-02T14:10:20Z

Another minor thing i noticed. Colored bubbles dont work inside (certain?) instances. Confirmed by going in Blood Furnance. Inside theres no coloring, while outside there is

Road-block · 2021-06-02T20:40:07Z

Another minor thing i noticed. Colored bubbles dont work inside (certain?) instances. Confirmed by going in Blood Furnance. Inside theres no coloring, while outside there is

That is likely a Blizzard limitation, same as for friendly Nameplates. Some frames cannot be modified when inside instances.

ConKou · 2021-06-04T16:07:29Z

I am getting the 'no player named xxx currently playing' spam in my chat pretty regularly and some Ace library lua errors when doing scan on the auction house with TSM. Since prat is the only not officially tbc supported addon i am running, im inclined to think theres a problem there, but i really can't tell for sure because the chat spam error comes and goes randomly.

Road-block · 2021-06-04T18:21:11Z

I am getting the 'no player named xxx currently playing' spam in my chat pretty regularly and some Ace library lua errors when doing scan on the auction house with TSM. Since prat is the only not officially tbc supported addon i am running, im inclined to think theres a problem there, but i really can't tell for sure because the chat spam error comes and goes randomly.

https://github.com/sylvanaar/prat-3-0/issues with the actual errors posted. If actual Prat files (not libraries) are not mentioned anywhere in the callstack it means nothing.

Road-block · 2021-06-09T13:21:45Z

Prat-3.0-3.9.1-5-571c1f6-bc.zip with fix for buttons module.

Daeveren · 2021-06-10T17:43:12Z

Prat-3.0-3.9.1-5-571c1f6-bc.zip with fix for buttons module.

I can confirm that the ScrollDown button now works!
Thank you!

dfherr · 2021-06-24T12:37:32Z

GROUP_ROSTER_UPDATE triggers on party and raid changes, but the updateParty method only checks for party units. RAID_ROSTER_UPDATE is also deprecated since MOP.

I just fixed it for myself like this:
in onModuleEnable:

- self:RegisterEvent("RAID_ROSTER_UPDATE", "updateRaid")
- if select(4, GetBuildInfo()) < 80000 and select(4, GetBuildInfo()) >= 20000 then
-     self:RegisterEvent("PARTY_MEMBERS_CHANGED", "updateParty")
- end
+self:RegisterEvent("GROUP_ROSTER_UPDATE", "updateGroup")

and right above the updateRaid/updateParty calls:

function module:updateGroup()
    if IsInRaid() then
      self:updateRaid()
    elseif IsInGroup() then
      self:updateParty()
    end
  end

probably not ideal, but a bit cleaner.

…ng out

Road-block · 2021-06-24T15:13:07Z

New package with some cleanup of dead code per dfherr comment

Prat-3.9.1-6-f65d85e-bc.zip

Also reminder that you can feed your WowUp or Ajour addon updater Install from URL with
https://github.com/Road-block/prat-3-0/releases/latest link
to get updates like this automatically.

- pick some modifications from upstream - add an editbox service file to prevent taint issues from touching ACTIVE_CHAT_EDIT_BOX global - embeds refresh for wotlkc - update interface numbers

Road-block added 3 commits May 25, 2021 02:15

extend classic check to include bcc

2089ea3

comment out or replace a bunch of obsolete toc version checks

2f07f70

replace dead code for group scaching in playernames module add a sanity check for toast button in originalbuttons module

fix backdrop for popupmessage and chatcopy frames (backwards compatible)

70ef04b

Road-block added 2 commits May 25, 2021 10:27

chatbubbles: fix shorten, transparent and coloring options

42a9262

bubbles: extend last to work on classic era

5df530f

Road-block changed the title ~~BCC compatibility + some outstanding problems fixes.~~ BCC compatibility + some older problem fixes. May 25, 2021

remove a leftover backdrop call

085c8d7

refactor backdrop compatibility for bcc and classic era

remove leftover reference to removed file

d9546b9

bubbles: color tail as well when the option is selected

85068e8

watchout-mods mentioned this pull request May 31, 2021

Fix missing backdrop due to UI changes in chat-bubbles and popup #211

Closed

buttons: fix classic check

571c1f6

upgrade some dead code in playernames module, ty to dfherr for pointi…

f65d85e

…ng out

Road-block mentioned this pull request Jun 24, 2021

TBC: Replace PARTY_MEMBERS_CHANGED with GROUP_ROSTER_UPDATE in PlayerNames.lua #226

Open

Road-block mentioned this pull request Jul 2, 2021

Mirror of 220 on original repo Legacy-of-Sylvanaar/prat-3-0#1

Merged

Wrath Classic refresh

49dde81

- pick some modifications from upstream - add an editbox service file to prevent taint issues from touching ACTIVE_CHAT_EDIT_BOX global - embeds refresh for wotlkc - update interface numbers

Road-block closed this Feb 6, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

BCC compatibility + some older problem fixes. #220

BCC compatibility + some older problem fixes. #220

Road-block commented May 24, 2021

Road-block commented May 25, 2021

Road-block commented May 25, 2021 •

edited

Loading

Road-block commented May 25, 2021 •

edited

Loading

Road-block commented May 27, 2021 •

edited

Loading

Daeveren commented May 28, 2021

Road-block commented May 28, 2021 •

edited

Loading

ConKou commented May 29, 2021

Road-block commented May 29, 2021 •

edited

Loading

Daeveren commented May 29, 2021

ConKou commented May 29, 2021

Daeveren commented May 30, 2021

Road-block commented May 30, 2021

ConKou commented May 31, 2021

Road-block commented May 31, 2021 •

edited

Loading

watchout-mods commented May 31, 2021

ConKou commented Jun 1, 2021

Road-block commented Jun 1, 2021

ConKou commented Jun 1, 2021

ConKou commented Jun 1, 2021 •

edited

Loading

Road-block commented Jun 1, 2021

ConKou commented Jun 2, 2021

Road-block commented Jun 2, 2021

ConKou commented Jun 4, 2021

Road-block commented Jun 4, 2021

Road-block commented Jun 9, 2021

Daeveren commented Jun 10, 2021

dfherr commented Jun 24, 2021 •

edited

Loading

Road-block commented Jun 24, 2021 •

edited

Loading

BCC compatibility + some older problem fixes. #220

BCC compatibility + some older problem fixes. #220

Conversation

Road-block commented May 24, 2021

Road-block commented May 25, 2021

Road-block commented May 25, 2021 • edited Loading

Road-block commented May 25, 2021 • edited Loading

Road-block commented May 27, 2021 • edited Loading

Daeveren commented May 28, 2021

Road-block commented May 28, 2021 • edited Loading

ConKou commented May 29, 2021

Road-block commented May 29, 2021 • edited Loading

Daeveren commented May 29, 2021

ConKou commented May 29, 2021

Daeveren commented May 30, 2021

Road-block commented May 30, 2021

ConKou commented May 31, 2021

Road-block commented May 31, 2021 • edited Loading

watchout-mods commented May 31, 2021

ConKou commented Jun 1, 2021

Road-block commented Jun 1, 2021

ConKou commented Jun 1, 2021

ConKou commented Jun 1, 2021 • edited Loading

Road-block commented Jun 1, 2021

ConKou commented Jun 2, 2021

Road-block commented Jun 2, 2021

ConKou commented Jun 4, 2021

Road-block commented Jun 4, 2021

Road-block commented Jun 9, 2021

Daeveren commented Jun 10, 2021

dfherr commented Jun 24, 2021 • edited Loading

Road-block commented Jun 24, 2021 • edited Loading

Road-block commented May 25, 2021 •

edited

Loading

Road-block commented May 25, 2021 •

edited

Loading

Road-block commented May 27, 2021 •

edited

Loading

Road-block commented May 28, 2021 •

edited

Loading

Road-block commented May 29, 2021 •

edited

Loading

Road-block commented May 31, 2021 •

edited

Loading

ConKou commented Jun 1, 2021 •

edited

Loading

dfherr commented Jun 24, 2021 •

edited

Loading

Road-block commented Jun 24, 2021 •

edited

Loading