Skip to content

Commit

Permalink
minor #54308 Add more explicit nullable types for default null values…
Browse files Browse the repository at this point in the history
… (alexandre-daubois)

This PR was merged into the 5.4 branch.

Discussion
----------

Add more explicit nullable types for default null values

| Q             | A
| ------------- | ---
| Branch?       | 5.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Issues        | -
| License       | MIT

Continuing to bring deprecation-free support for PHP 8.4 (https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated)

If this gets merged, I'll take care of adding missing ones in upper branches if not done during upmerge 🙂

Commits
-------

e9d30bac03 Add more explicit nullable types for default null values
  • Loading branch information
nicolas-grekas committed Mar 19, 2024
2 parents b3e9cdb + d244d9a commit 9e070a0
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Tests/Fixtures/MockStream/MockStream.php
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ class MockStream
* @param string|null $opened_path If the path is opened successfully, and STREAM_USE_PATH is set in options,
* opened_path should be set to the full path of the file/resource that was actually opened
*/
public function stream_open(string $path, string $mode, int $options, string &$opened_path = null): bool
public function stream_open(string $path, string $mode, int $options, ?string &$opened_path = null): bool
{
return true;
}
Expand Down

0 comments on commit 9e070a0

Please sign in to comment.