[make:*-test] Use the new WebTestAssertionsTrait methods in the generated functional tests

[adrienlucas]

Hi, this PR is to fix the way of calling the assertions static methods of PHPunit in the generated unit and functional tests.

First commit : As pointed out in this article, we should not be calling the assertions using $this->assert* but instead with static::assert*.

Second commit : To go further, we can use the new assertion API provided by the WebTestCase.

I don't kown if this could be considered a BC break... but i hope not.

[weaverryan]

Hey @adrienlucas!

Thank you for this! So, let's look at the 2 commits independently:

1. self:: vs $this-> for the assert functions. For this, we should be consistent with Symfony's core and what's recommended in Symfony's docs, which is $this-> currently. We could discuss that on an issue on symfony/symfony-docs. I don't feel too strongly, but MakerBundle will follow that lead.

2. About using the new assertion API in WebTestCase. I <3 this idea. However, as this feature is only available in Symfony 4.3 or higher, we need to make the generated code smart: it needs to use the old code if the user doesn't have the new WebTestAssertions trait and new code if they do. We could determine that in the maker and pass it in as a variable. Could you make that change?

Thanks!

[adrienlucas]

@weaverryan

1. I get it, while being a little disappointed about it... Is there an explanation for using a non-statc call on a static method here ? I will fix it anyway, to keep consistency.
2. Will do !

To go further : should i try to assess Panther installation too, and make the generated test extends the PantherTestCase when possible ?

[B-Galati]

For the 1st one, see sebastianbergmann/phpunit#1914

[adrienlucas]

@B-Galati thank you !

@weaverryan does the new version of this PR suits more the needs ?

should we try to use travis to test against the symfony/framework-bundle:dev-master dependency, or something else to ensure the two versions of the possibly generated functional tests are working ?

(i renamed the PR to reflect the new intent)

[weaverryan]

Thank you Adrien!