PSR HTTP message converters for controllers #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
commented
Feb 16, 2021
Comment on lines
+54
to
+61
| $container->services() | ||
| ->set('nyholm.psr_factory', Psr17Factory::class) | ||
| ->alias(ResponseFactoryInterface::class, 'nyholm.psr_factory') | ||
| ->alias(ServerRequestFactoryInterface::class, 'nyholm.psr_factory') | ||
| ->alias(StreamFactoryInterface::class, 'nyholm.psr_factory') | ||
| ->alias(UploadedFileFactoryInterface::class, 'nyholm.psr_factory') | ||
| ; |
There was a problem hiding this comment.
💡 The recipe for nyholm/psr7 provides this piece of configuration already.
derrabus
commented
Feb 16, 2021
Comment on lines
+62
to
+69
| $container->services() | ||
| ->defaults()->autowire()->autoconfigure() | ||
| ->set(HttpFoundationFactoryInterface::class, HttpFoundationFactory::class) | ||
| ->set(HttpMessageFactoryInterface::class, PsrHttpFactory::class) | ||
| ->set(PsrResponseListener::class) | ||
| ->set(PsrServerRequestResolver::class) | ||
| ; |
There was a problem hiding this comment.
💡 A new recipe for psr-http-message-bridge should provide this piece of configuration.
derrabus
force-pushed
the
improvement/message-conversion
branch
from
2cf933e to
ed9e273
Compare
|
CI failure is unrelated. I'll work on a separate PR to upgrade the CI for the year 2021. 😃 /edit: #90 |
derrabus
force-pushed
the
improvement/message-conversion
branch
2 times, most recently
from
2068ce5 to
2ca0157
Compare
nicolas-grekas
approved these changes
Feb 16, 2021
|
Recipe: symfony/recipes#899 |
dunglas
approved these changes
Feb 16, 2021
derrabus
force-pushed
the
improvement/message-conversion
branch
from
2ca0157 to
d5ecc48
Compare
derrabus
force-pushed
the
improvement/message-conversion
branch
from
d5ecc48 to
aa26e61
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes to add two classes to
symfony/psr-http-message-bridgethat have been removed fromsensio/framework-extra-bundle.By adding
PsrServerRequestResolverandPsrResponseListenerto its service container, with autowring and autoconfiguring enabled, an application gains the ability to operate controllers on PSR-7 message objects instead of HttpFoundation.This is especially useful if a developer wants to reuse generic packages like
league/oauth2-server.Configuration files for autowiring the two classes can be provided as Flex recipes.