Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI failures with Xdebug 3 and test on PHP 7.4/8.0 as well #90

Merged
merged 1 commit into from
Feb 16, 2021
Merged

Fix CI failures with Xdebug 3 and test on PHP 7.4/8.0 as well #90

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,22 +8,27 @@ cache:
env:
global:
- PHPUNIT_FLAGS="-v"
- SYMFONY_PHPUNIT_VERSION=9.5
- SYMFONY_PHPUNIT_DIR="$HOME/symfony-bridge/.phpunit"

matrix:
fast_finish: true
include:
# Minimum supported dependencies with the latest and oldest PHP version
- php: 7.3
- php: 7.4
env: COMPOSER_FLAGS="--prefer-stable --prefer-lowest" SYMFONY_DEPRECATIONS_HELPER="weak_vendors"

- php: 7.1
env: SYMFONY_PHPUNIT_VERSION=7.5
- php: 7.2
env: SYMFONY_PHPUNIT_VERSION=8.5
- php: 7.3
env: COVERAGE=true PHPUNIT_FLAGS="-v --coverage-text"
- php: 7.4
env: COVERAGE=true PHPUNIT_FLAGS="-v --coverage-text" XDEBUG_MODE=coverage
- php: 8.0

# Latest commit to master
- php: 7.3
- php: 7.4
env: STABILITY="dev"

allow_failures:
Expand Down
2 changes: 1 addition & 1 deletion Tests/Factory/AbstractHttpMessageFactoryTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ public function testCreateResponse()
$cookieHeader = $psrResponse->getHeader('Set-Cookie');
$this->assertIsArray($cookieHeader);
$this->assertCount(1, $cookieHeader);
$this->assertRegExp('{city=Lille; expires=Wed, 13-Jan-2021 22:23:01 GMT;( max-age=\d+;)? path=/; httponly}i', $cookieHeader[0]);
$this->assertMatchesRegularExpression('{city=Lille; expires=Wed, 13-Jan-2021 22:23:01 GMT;( max-age=\d+;)? path=/; httponly}i', $cookieHeader[0]);
}

public function testCreateResponseFromStreamed()
Expand Down
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
"symfony/http-foundation": "^4.4 || ^5.0"
},
"require-dev": {
"symfony/phpunit-bridge": "^4.4 || ^5.0",
"symfony/phpunit-bridge": "^4.4.19 || ^5.2",
"nyholm/psr7": "^1.1"
},
"suggest": {
Expand Down