Improved the HTTPCache examples mentioning s-maxage #13359
Conversation
|
@mpdude could you please review this? Thanks! |
| .. note:: | ||
|
|
||
| Using the ``setSharedMaxAge()`` may seem equivalent to using both ``setPublic()`` | ||
| and ``setMaxAge()`` methods. However, their behavior is different in a |
There was a problem hiding this comment.
My suggestion would be to refer to https://tools.ietf.org/html/rfc7234#section-4.2.4:
"However, the setSharedMaxAge() method and the corresponsing s-maxage setting have the additional implication of prohibiting a cache to use a stale response in particular error scenarios. See RFC 7234 Section 4.2.4 for details."
(Does "stale" make sense in the context of this page, is it a term we have used or defined before?)
There was a problem hiding this comment.
Thanks for your review! I added this while merging the pull request.
|
Thank you @javiereguiluz for picking this up and sorry – I must have missed the notification back in March. I have a small recommendation/addition to make, but I'd like to leave it up to you to decide. Re-reading the docs on the topic, I find that we might want to dedicate a few lines to the difference between |
Fixes #12934.