Fix issue between Encore.enableIntegrityHashes() and filenames with a query-string
#1349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kocal
force-pushed
the
fix-integrity-hashes-original-asset
branch
from
7e23c72
to
f588b5a
Compare
…in "integrity" map
Kocal
force-pushed
the
fix-integrity-hashes-original-asset
branch
from
f588b5a
to
c965684
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow #1345
When working on symfony/webpack-encore-bundle#237, I haven't able to see integrity hashes added on
<link>tags, because my project uses query-string in generated filenames, but the bundle was not able to get those integrity hashes (because theentrypoints.jsonfile contained"/build/sentry.js": "sha384-hash"instead of"/build/sentry.js?v=b86ff72e": "sha384-hash")