Optimize transformer #24
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisLing1
force-pushed
the
import-perf
branch
from
65962a9 to
45cb03f
Compare
ChrisLing1
changed the title
rsantos-varicent
requested changes
Aug 18, 2022
tap_s3_csv/transform.py
Outdated
| @@ -169,10 +175,6 @@ def transform_recur(self, data, schema, path, source_type=None): | |||
| if not isinstance(types, list): | |||
There was a problem hiding this comment.
at this point, types is expected to be lists from transform_schema_recur. can remove this check
tap_s3_csv/sync.py
Outdated
| @@ -249,15 +249,19 @@ def sync_csv_file(config, file_handle, s3_path, table_spec, stream, timers={}): | |||
| config, source_type_map) | |||
| timers['resolve_fields'] += time.time() - start | |||
|
|
|||
| # modify schema to put null as the last time to check for | |||
There was a problem hiding this comment.
"time" -> "type"
put this comment at the top of transform_schema_recur in transform.py so we know what the function is expected to do
rsantos-varicent
approved these changes
Aug 19, 2022
ChrisLing1
force-pushed
the
import-perf
branch
from
499f797 to
bcef23f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.