Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.x] JIT sends 304 responses for deleted originals #171

Open
michael-e opened this issue Aug 27, 2019 · 0 comments
Open

[1.x] JIT sends 304 responses for deleted originals #171

michael-e opened this issue Aug 27, 2019 · 0 comments

Comments

@michael-e
Copy link
Member

michael-e commented Aug 27, 2019 •
edited
Loading

If an original image file has been deleted, $last_modified_gmt and $etag will be null. This will always make one of the conditions in this line return true.

Thus, JIT will send a 304 response for revalidation requests (If-None-Match resp. If-Modified-Since). Forever! Which is wrong, obviously.

I will send a PR to 1.x.
michael-e added a commit to michael-e/jit_image_manipulation that referenced this issue Aug 27, 2019
@michael-e
Don't allow empty values for comparison
a2e8228 
Fixes symphonycms#171 (JIT sends 304 responses for deleted originals)
@michael-e michael-e mentioned this issue Aug 27, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@michael-e