Add xlinkHref property to SurgicalElement

Add updateElementAttributeNS Bump version to 0.5.3
syranide · May 16, 2018 · ee2dfa3 · ee2dfa3
1 parent 3446e2f
commit ee2dfa3
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 1 deletion.
diff --git a/npm-build/surgical/package.json b/npm-build/surgical/package.json
@@ -1,6 +1,6 @@
 {
   "name": "surgical",
-  "version": "0.5.2",
+  "version": "0.5.3",
   "license": "MIT",
   "description": "Surgical is a declarative JavaScript library with native DOM flexibility and performance, for building fast UIs.",
   "author": "Andreas Svensson <[email protected]>",

diff --git a/packages/surgical/SurgicalElement.js b/packages/surgical/SurgicalElement.js
@@ -1,5 +1,6 @@
 import SurgicalBaseElement from './SurgicalBaseElement';
 import updateElementAttribute from './core/updateElementAttribute';
+import updateElementAttributeNS from './core/updateElementAttributeNS';
 import updateElementAttributes from './core/updateElementAttributes';
 import updateElementProxyEventListeners from './core/updateElementProxyEventListeners';
 import updateStyleProperties from './core/updateStyleProperties';
@@ -14,6 +15,7 @@ export default class SurgicalElement extends SurgicalBaseElement {
     this.nodeStyle = node.style;
 
     updateElementAttribute(node, 'class', props.className, null);
+    updateElementAttributeNS(node, 'http://www.w3.org/1999/xlink', 'xlink:href', props.xlinkHref, null);
     updateElementAttributes(node, props.attributes, null);
     updateStyleProperties(this.nodeStyle, props.style, null);
     this.eventListenersInstance = updateElementProxyEventListeners(node, null, props.listeners, null);
@@ -30,6 +32,7 @@ export default class SurgicalElement extends SurgicalBaseElement {
     //}
 
     updateElementAttribute(node, 'class', nextProps.className, lastProps.className);
+    updateElementAttributeNS(node, 'http://www.w3.org/1999/xlink', 'xlink:href', nextProps.xlinkHref, lastProps.xlinkHref);
     updateElementAttributes(node, nextProps.attributes, lastProps.attributes);
     updateStyleProperties(this.nodeStyle, nextProps.style, lastProps.style);
     this.eventListenersInstance = updateElementProxyEventListeners(node, this.eventListenersInstance, nextProps.listeners, lastProps.listeners);

diff --git a/packages/surgical/core/updateElementAttributeNS.js b/packages/surgical/core/updateElementAttributeNS.js
@@ -0,0 +1,9 @@
+export default function updateElementAttributeNS(node, namespaceURI, name, nextValue, lastValue) {
+  if (nextValue !== lastValue) {
+    if (nextValue != null && nextValue !== false) {
+      node.setAttributeNS(namespaceURI, name, (nextValue === true ? '' : nextValue));
+    } else if (lastValue != null && lastValue !== false) {
+      node.removeAttributeNS(namespaceURI, name);
+    }
+  }
+}