Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(agent): add "sysdig_api_endpoint" in dragent.yaml based on the region #2072

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

legobrick
Copy link
Collaborator

@legobrick legobrick commented Dec 11, 2024

What this PR does / why we need it:

Making life easier when setting up the response actions feature (More here)

Checklist

  • Title of the PR starts with type and scope, (e.g. feat(agent,node-analyzer,sysdig-deploy):)
  • Chart Version bumped for the respective charts
  • Variables are documented in the README.md (or README.tpl in some charts)
  • Check GithubAction checks (like lint) to avoid merge-check stoppers
  • All test files are added in the tests folder of their respective chart and have a "_test" suffix

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR title does not comply with regex: ^(\w*)(?:\(([\w\$\.\,\-\*\s]*)\))?\:\s?(.*)$!
Check PR guidelines at https://github.com/sysdiglabs/charts/blob/main/README.md#pull-requests

@legobrick legobrick changed the title feat(agent) add "sysdig_api_endpoint" in dragent.yaml based on the region feat(agent): add "sysdig_api_endpoint" in dragent.yaml based on the region Dec 11, 2024
@github-actions github-actions bot dismissed their stale review December 11, 2024 11:25

All good!

@legobrick legobrick force-pushed the paolo-responder-ca branch 3 times, most recently from 1719a5a to 3080a86 Compare December 11, 2024 21:43
@legobrick legobrick marked this pull request as ready for review December 11, 2024 22:17
@legobrick legobrick requested a review from a team as a code owner December 11, 2024 22:17
@legobrick legobrick enabled auto-merge (squash) December 11, 2024 22:18
@mavimo mavimo force-pushed the paolo-responder-ca branch 2 times, most recently from c5d2c9a to 4d4e2cc Compare December 31, 2024 11:43
@mavimo mavimo force-pushed the paolo-responder-ca branch from 4d4e2cc to 78befdd Compare January 2, 2025 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants