Update the webpack configuration in Angular Plugin #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gs for issue #11580 and for System.import
larixer
reviewed
Nov 7, 2018
src/plugins/AngularPlugin.ts
Outdated
| * It's necessary to remove the @angular part and fix the issue by enabling | ||
| * the proper module.rules.Rule for @angular/core/*.js files(see above). | ||
| */ | ||
| /angular[\\\/]core/, | ||
| path.join(builder.require.cwd, 'src'), |
There was a problem hiding this comment.
Do we really need to append src here? Could you check Svyat? I think we don't need to make assumption that all the package source code will be inside src and everything will work even if we don't append src here
There was a problem hiding this comment.
As far as I am concerned, we can remove the last two arguments in webpack.ContextReplacementPlugin and just pass the correct regexp angular[\\\/]core.
Tested the project with webpack.ContextReplacementPlugin(/angular[\\\/]core/) for the Angular ^4, ^5, ^6, ^7 versions.
|
Many thanks @AndSviat ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The workaround with webpack.ContextReplacementPlugin for angular/angular#11580 doesn’t really work for Angular 4, 5, 6, and 7:
Warning #1: https://prnt.sc/lezevh
Warning #2: https://prnt.sc/lezfmd
The update brings the changes in
AngularPlugin.tsto suppress the warnings.