scratch-buffers: fix 'global.scratch_buffers_count.queued' bug #3355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaborznagy
force-pushed
the
fix-scratch-buffer-stats
branch
from
7949ae1 to
a76d922
Compare
|
Build SUCCESS |
MrAnno
previously approved these changes
Jul 12, 2020
Kokan
reviewed
Jul 13, 2020
gaborznagy
force-pushed
the
fix-scratch-buffer-stats
branch
from
a76d922 to
b939fd7
Compare
|
Build FAILURE |
MrAnno
previously approved these changes
Jul 14, 2020
gaborznagy
force-pushed
the
fix-scratch-buffer-stats
branch
from
b939fd7 to
9ffcb72
Compare
|
Build SUCCESS |
unary minus operator should not be used on unsigned variables (GPtrArray->len). Signed-off-by: Gabor Nagy <[email protected]>
gaborznagy
force-pushed
the
fix-scratch-buffer-stats
branch
from
9ffcb72 to
34b99c4
Compare
|
Build SUCCESS |
Signed-off-by: Gabor Nagy <[email protected]>
gaborznagy
force-pushed
the
fix-scratch-buffer-stats
branch
from
34b99c4 to
6c1911c
Compare
|
Build SUCCESS |
MrAnno
approved these changes
Jul 15, 2020
Kokan
approved these changes
Jul 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to some bug, the
global.scratch_buffers_count.queuedcould shown an invalid value (e.g. 2^32 value, while the actual usage was just decreased to 0).This bug only affected the stats_counter value, not the actual memory usage (i.e. memory usage was fine before).