Input/output byte metrics for HTTP destination and non-blocking sources/destinations #4440
+487
−174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build FAILURE |
MrAnno
added a commit
to MrAnno/syslog-ng
that referenced
this pull request
Apr 24, 2023
Signed-off-by: László Várady <[email protected]>
|
@kira-syslogng do stresstest |
|
Kira-stress-test: Build SUCCESS |
MrAnno
added a commit
to MrAnno/syslog-ng
that referenced
this pull request
Apr 24, 2023
Signed-off-by: László Várady <[email protected]>
|
Build FAILURE |
MrAnno
added a commit
to MrAnno/syslog-ng
that referenced
this pull request
Apr 24, 2023
Signed-off-by: László Várady <[email protected]>
|
@kira-syslogng do stresstest |
|
Kira-stress-test: Build SUCCESS |
MrAnno
added a commit
to MrAnno/syslog-ng
that referenced
this pull request
Apr 25, 2023
Signed-off-by: László Várady <[email protected]>
MrAnno
added a commit
to MrAnno/syslog-ng
that referenced
this pull request
Apr 25, 2023
Signed-off-by: László Várady <[email protected]>
MrAnno
added a commit
to MrAnno/syslog-ng
that referenced
this pull request
Apr 25, 2023
Signed-off-by: László Várady <[email protected]>
|
@kira-syslogng do stresstest |
|
Build FAILURE |
StatsByteCounter allows representing "big" accumulating byte-based metrics even on 32-bit architectures, where a simple stats-counter would overflow after 4 GiB. When 64-bit counters are available, they will be used. If not, the counters lose precision but are able to represent larger values. The current implementation is not thread-safe, reimplement it using a CAS loop when needed. Signed-off-by: László Várady <[email protected]>
Signed-off-by: László Várady <[email protected]>
MrAnno
added a commit
to MrAnno/syslog-ng
that referenced
this pull request
Apr 25, 2023
Signed-off-by: László Várady <[email protected]>
|
@kira-syslogng do stresstest |
|
Build FAILURE |
|
Kira-stress-test: Build SUCCESS |
Note: this metric has been added to the destination worker instead of the driver, because the API is currently not thread-safe. Signed-off-by: László Várady <[email protected]>
Signed-off-by: László Várady <[email protected]>
Signed-off-by: László Várady <[email protected]>
Signed-off-by: László Várady <[email protected]>
Signed-off-by: László Várady <[email protected]>
Signed-off-by: László Várady <[email protected]>
Signed-off-by: László Várady <[email protected]>
Signed-off-by: László Várady <[email protected]>
alltilla
approved these changes
Apr 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces byte-based input/output metrics for all non-blocking sources and destinations and for the HTTP destination.
On 32-bit architectures, metrics use
SCU_KIBand cache smaller values in order to represent values larger than 4 GiB.These metrics show the serialized message sizes (protocol-specific header/framing length is not included).
The incoming message length is also available as a hard macro:
$RAWMSG_SIZE.