Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change doubly LL to singly LL in hash table #15

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Change doubly LL to singly LL in hash table #15

wants to merge 1 commit into from

Conversation

iLeafy11
Copy link

No description provided.

jserv
jserv requested changes Apr 14, 2023
View reviewed changes
Copy link
Contributor

@jserv jserv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Run clang-format -i *.[ch] for consistent style.

jserv
jserv reviewed Apr 14, 2023
View reviewed changes
map-reduce/word-count.c Outdated Show resolved Hide resolved
jserv
jserv reviewed Apr 14, 2023
View reviewed changes
map-reduce/word-count.c Outdated Show resolved Hide resolved
jserv
jserv reviewed Apr 14, 2023
View reviewed changes
map-reduce/word-count.c Outdated Show resolved Hide resolved
jserv
jserv reviewed Apr 14, 2023
View reviewed changes
map-reduce/word-count.c Outdated Show resolved Hide resolved
jserv
jserv reviewed Apr 15, 2023
View reviewed changes
map-reduce/word-count.c
struct ht_node *tmp = list_element(iter, struct ht_node, list);
struct hlist_head *head = &h->buckets[bkt];
struct hlist_node *iter;
hlist_for_each(iter, head)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update .clang-format to recognize hlist_for_each as a for-each macro.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You shall indent this source file accordingly.

jserv
jserv requested changes Apr 15, 2023
View reviewed changes
Copy link
Contributor

@jserv jserv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read https://cbea.ms/git-commit/ carefully and refine your git commit messages.

jserv
jserv requested changes Apr 17, 2023
View reviewed changes
Copy link
Contributor

@jserv jserv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improve git commit messages. You should summarize the motivation and consideration to make such changes. In addition, the subject ought to be revised.

@iLeafy11
Copy link
Author

iLeafy11 commented Apr 18, 2023 •
edited
Loading

There'll be errors occur when having an input like this:
a aaa a
Will refine the git commit messages after solving this issue.(solved)

@jserv
Copy link
Contributor

jserv commented Aug 26, 2023

There'll be errors occur when having an input like this: a aaa a Will refine the git commit messages after solving this issue.(solved)

Would you continue working on this pull request?

@iLeafy11
Copy link
Author

There'll be errors occur when having an input like this: a aaa a Will refine the git commit messages after solving this issue.(solved)

Would you continue working on this pull request?

Yes, I’ll continue to work on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jserv jserv jserv requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iLeafy11 @jserv