merge: #2735

2735: chore(dal,web,langjs,sdf,pkg): remove confirmations r=paulocsanz a=paulocsanz Co-authored-by: Paulo Cabral <[email protected]> Co-authored-by: stack72 <[email protected]>
systeminit · Sep 12, 2023 · 109e4b7 · 109e4b7
2 parents 32e4c00 + 7204517
commit 109e4b7
Show file tree

Hide file tree

Showing 86 changed files with 271 additions and 3,376 deletions.
diff --git a/app/web/src/api/sdf/dal/func.ts b/app/web/src/api/sdf/dal/func.ts
@@ -2,7 +2,6 @@ export enum FuncVariant {
   Attribute = "Attribute",
   CodeGeneration = "CodeGeneration",
   Action = "Action",
-  Confirmation = "Confirmation",
   Qualification = "Qualification",
   Validation = "Validation",
 }
@@ -20,10 +19,6 @@ export const CUSTOMIZABLE_FUNC_TYPES = {
     pluralLabel: "Code Generations",
     singularLabel: "Code Generation",
   },
-  [FuncVariant.Confirmation]: {
-    pluralLabel: "Confirmations",
-    singularLabel: "Confirmation",
-  },
   [FuncVariant.Qualification]: {
     pluralLabel: "Qualifications",
     singularLabel: "Qualification",

diff --git a/app/web/src/components/AssetFuncAttachModal.vue b/app/web/src/components/AssetFuncAttachModal.vue
@@ -306,11 +306,6 @@ const newFuncOptions = (
         type: "codeGenerationOptions",
         ...baseOptions,
       };
-    case FuncVariant.Confirmation:
-      return {
-        type: "confirmationOptions",
-        ...baseOptions,
-      };
     case FuncVariant.Qualification:
       return {
         type: "qualificationOptions",
@@ -335,7 +330,6 @@ const attachToLeafFunctionOrAction = (
   associations: FuncAssociations,
 ): FuncAssociations =>
   associations.type === "codeGeneration" ||
-  associations.type === "confirmation" ||
   associations.type === "qualification" ||
   associations.type === "action"
     ? {
@@ -403,7 +397,6 @@ const attachExistingFunc = async () => {
       switch (associations.type) {
         case "action":
         case "codeGeneration":
-        case "confirmation":
         case "qualification":
           updatedAssocations = attachToLeafFunctionOrAction(
             props.schemaVariantId,

diff --git a/app/web/src/components/FuncEditor/ConfirmationDescriptionModal.vue b/app/web/src/components/FuncEditor/ConfirmationDescriptionModal.vue
diff --git a/app/web/src/components/FuncEditor/ConfirmationDetails.vue b/app/web/src/components/FuncEditor/ConfirmationDetails.vue
diff --git a/app/web/src/components/FuncEditor/FuncDetails.vue b/app/web/src/components/FuncEditor/FuncDetails.vue
@@ -153,17 +153,6 @@
             :schemaVariantId="schemaVariantId"
             @change="updateFunc"
           />
-          <ConfirmationDetails
-            v-if="
-              editingFunc.associations &&
-              editingFunc.associations.type === 'confirmation'
-            "
-            ref="detachRef"
-            v-model="editingFunc.associations"
-            :disabled="changeSetsStore.headSelected"
-            :schemaVariantId="schemaVariantId"
-            @change="updateFunc"
-          />
           <QualificationDetails
             v-if="
               editingFunc.associations &&
@@ -273,7 +262,6 @@ import FuncArguments from "./FuncArguments.vue";
 import ActionDetails from "./ActionDetails.vue";
 import AttributeBindings from "./AttributeBindings.vue";
 import CodeGenerationDetails from "./CodeGenerationDetails.vue";
-import ConfirmationDetails from "./ConfirmationDetails.vue";
 import ValidationDetails from "./ValidationDetails.vue";
 import QualificationDetails from "./QualificationDetails.vue";
 
@@ -291,7 +279,6 @@ type DetachType =
   | InstanceType<typeof ActionDetails>
   | InstanceType<typeof AttributeBindings>
   | InstanceType<typeof CodeGenerationDetails>
-  | InstanceType<typeof ConfirmationDetails>
   | InstanceType<typeof ValidationDetails>
   | InstanceType<typeof QualificationDetails>;
 
@@ -351,7 +338,6 @@ const isConnectedToOtherAssetTypes = computed(() => {
     const associations = editingFunc.value.associations;
     switch (associations.type) {
       case "codeGeneration":
-      case "confirmation":
       case "qualification":
         return (
           associations.schemaVariantIds.length > 1 ||