Merge pull request #5102 from systeminit/fix/api-test-adjustment

fixup: API tests failure methods
systeminit · Dec 10, 2024 · b0ca65b · b0ca65b
2 parents 730ca7d + be6b53c
commit b0ca65b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/.github/workflows/e2e-validation.yml b/.github/workflows/e2e-validation.yml
@@ -127,7 +127,7 @@ jobs:
     runs-on: ubuntu-latest
     needs: cypress-tests
     environment: ${{ inputs.environment }}
-    if: ${{ failure() }} && github.ref == 'refs/heads/main' }}
+    if: ${{ failure() && github.ref == 'refs/heads/main' }}
     steps:
       - name: Download all artifacts
         uses: actions/download-artifact@v4

diff --git a/.github/workflows/run-api-test.yml b/.github/workflows/run-api-test.yml
@@ -111,7 +111,7 @@ jobs:
             # Check the exit code
             if [ -z "$exit_code" ]; then
               echo "Deno task succeeded [ or the orchestration failed for a totally non-valid reason ]!"
-              break
+              exit 0
             fi
 
             n=$((n+1))
@@ -145,7 +145,7 @@ jobs:
     runs-on: ubuntu-latest
     needs: api-test
     environment: ${{ inputs.environment }}
-    if: ${{ failure() }} && github.ref == 'refs/heads/main' }}
+    if: ${{ failure() && github.ref == 'refs/heads/main' }}
     steps:
       - name: Download all artifacts
         uses: actions/download-artifact@v4