final fixup

.github/workflows/run-api-test.yml

@@ -112,14 +112,7 @@ jobs:
             
             # Check the exit code
             if [ -z "$exit_code" ]; then
-              echo "Deno task succeeded [ or this failed for a totally non-valid reason ]!"
-
-              # Randomly make it fail to test logic
-              if [[ "$(( ( RANDOM % 5 )  + 1 ))" == "3" ]]; then
-                echo "last_exit_code=53" >> "$GITHUB_ENV"
-                exit 53
-              fi 
-
+              echo "Deno task succeeded [ or the orchestration failed for a totally non-valid reason ]!"
               break
             fi
 
@@ -147,14 +140,14 @@ jobs:
         if: ${{ failure() && env.last_exit_code == '53' }}
         uses: actions/upload-artifact@v3
         with:
-          name: debug-${{ matrix.tests.name }}
+          name: ${{ matrix.tests.name }}
           path: artifacts/${{ matrix.tests.name }}
 
   on-failure:
     runs-on: ubuntu-latest
     needs: api-test
     environment: ${{ inputs.environment }}
-    if: ${{ failure() }} #&& github.ref == 'refs/heads/main' }} #TODO(johnrwatson): disable comment before merging
+    if: ${{ failure() }} && github.ref == 'refs/heads/main' }}
     steps:
       - name: Download all artifacts
         uses: actions/download-artifact@v3
@@ -189,7 +182,7 @@ jobs:
               }" 
           fi
       - run: |
-          # Always send the Internal Slack Notification if failure detected, even if we didn't page
+          # Always send the Internal Slack Notification if failure detected, regardless of error source
           curl --location "${{ secrets.SLACK_WEBHOOK_URL }}" -X POST \
             --header 'Content-type: application/json' \
             --data "{\"text\": \":si: Failed API Tests for ${{ inputs.environment }}: <https://github.com/systeminit/si/actions/runs/$GITHUB_RUN_ID|:test_tube: Link>\"}"