chore(deps): Updating Rust Deps #5057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Required so we can upgrade our version of rustls for a vulnerability
github-actions
bot
added
A-si-settings
nickgerace
previously approved these changes
Dec 3, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 3, 2024
chore(deps): Updating Rust Deps
|
/try |
fnichol
reviewed
Dec 3, 2024
| "logging", | ||
| "ring", | ||
| "tls12", | ||
| ], |
There was a problem hiding this comment.
I'm reasonbly sure we don't want default-features = false as rustls won't have feature support anymore for tls12/ring/etc
There was a problem hiding this comment.
Commented here: #5057 (comment)
|
we should add the vulnerabillity-fix label if this is what that's intended for |
"Specifying default-features = false when depending on rustls will remove the dependency on aws-lc-rs." Sources... - https://github.com/rustls/rustls/tree/v/0.23.19?tab=readme-ov-file#platform-support - https://github.com/rustls/rustls/tree/v/0.23.19?tab=readme-ov-file#cryptography-providers - https://docs.rs/rustls/0.23.19/rustls/crypto/struct.CryptoProvider.html Co-authored-by: Fletcher Nichol <[email protected]> Signed-off-by: Nick Gerace <[email protected]>
|
We added a second commit to provide context to the change. And @johnrwatson just did it! |
fnichol
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required so we can upgrade our version of rustls for a vulnerability