Add pipeline to restart SDF/Rebaser/Pinga units on relevant nodes #5130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnrwatson
changed the title
johnrwatson
changed the title
johnrwatson
force-pushed
the
feat/add-unit-restart-for-memory-management
branch
2 times, most recently
from
d5c8f71 to
4ade1e1
Compare
sprutton1
reviewed
Dec 13, 2024
| jobs: | ||
|
|
||
| restart-rebaser: | ||
| uses: ./.github/workflows/instance-refresh.yml |
There was a problem hiding this comment.
do you mean to use the instance-refresh here or the new service-restart you wrote?
There was a problem hiding this comment.
Oh goodness, great catch
johnrwatson
force-pushed
the
feat/add-unit-restart-for-memory-management
branch
from
6af74a1 to
aeba0ea
Compare
sprutton1
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new pipeline which we can trigger that will restart the service replicas that are impacted by our current run-away memory issue. It will basically quickly drop the replicas and bring them back. For SDF it pushes the FE into maintenance mode first to give a bit of better user experience, all the other services are gracefully stopped so they should finish up their current work before attempting to be started again.
In theory, it's much better to take just one node offline at a time, but it would require a fair bit more re-work in our toolbox to let us do it.
We can schedule this like a maintenance event (using the maintenance mode) and it should be very minimally impactful for the users.
This is untestable until I merge it, because the workflow doesn't exist in the UI/API until it's present on main at least once